Add API and address config to enable testing bootz service in tests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your CL is failing some tests, please take a look here: https://github.com/openconfig/bootz/actions/runs/6435283126/job/17476203671?pr=64 |
LiamWalsh98
force-pushed
the
bootz_address_config
branch
from
b7dd76d to
63e414d
Compare
|
force push was to amend commit message |
|
build is failing presumably from a cherry-pick going wrong. will investigate |
LiamWalsh98
force-pushed
the
bootz_address_config
branch
from
7b1d19b to
c3c9286
Compare
|
squashed together several check fixes to reduce clutter |
|
Hey Liam, unclear if this is awaiting review, if it is, please set the PR as "Ready for review" Thanks :) |
Not quite yet, will mark as ready soon. |
|
redundant after #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revisits changes from #28 (rebased onto 6401680)
I will add the remaining changes to this draft PR and promote it for merging when finished.