Add tests for parser #164
Merged
Add tests for parser #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robshakir
approved these changes
Jun 30, 2021
pkg/yang/parse.go
Outdated
| @@ -77,9 +77,8 @@ func (s *Statement) SubStatements() []*Statement { return s.statements } | |||
|
|
|||
| // String returns s's tree as a string. | |||
There was a problem hiding this comment.
Best just to remove this given that it doesn't seem like it does anything particularly useful? Or is this part of the interface that needs to be implemented?
If it's not, should we create some simple implementation here (YANG statement at line X, or even. just <YANG Statement>)?
There was a problem hiding this comment.
I'll delete this since it doesn't seem to be need by anything else in goyang as well as ygot.
If someone complains I will add an implementation for it. Added tracking bug at #193
@robshakir, I didn't do a merge on the older PRs before merging, leading to this breakage on HEAD. Is there a setting in goyang you can enable to make it similar ygot where you need to merge into master first before merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parseis now fully tested.