Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error case with intentional empty services #439

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix error case with intentional empty services #439

merged 1 commit into from
Oct 9, 2023

Conversation

alexmasi
Copy link
Contributor

@alexmasi alexmasi commented Oct 9, 2023

this should not cause a failure showing the topology

@alexmasi alexmasi requested a review from bormanp October 9, 2023 23:24
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6462695895

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 65.8%
Totals Coverage Status
Change from base Build 6436017080: 0.04%
Covered Lines: 4048
Relevant Lines: 6152
💛 - Coveralls

bormanp
bormanp approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@bormanp bormanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmasi alexmasi merged commit 921a83f into main Oct 9, 2023
@alexmasi alexmasi deleted the show branch October 9, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bormanp bormanp bormanp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexmasi @bormanp