Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config leaf for bgp allocate-vpn-label for L3VPN IPv[46] unicast address families #1001

Closed
wants to merge 5 commits into from

Conversation

vall-arista
Copy link

@vall-arista vall-arista commented Nov 16, 2023

Adding extra configuration parameters to /network-instances/network-instance/protocols/protocol/bgp/global/afi-safis/afi-safi/[l3vpn-ipv4-unicast|l3vpn-ipv6-unicast]/[config|state]

Arista CLI knob

router bgp 100
       address-family vpn-ipv4
               neighbor default encapsulation mpls next-hop-self received-vpnv4-routes
       !
      address-family vpn-ipv6
                neighbor default encapsulation mpls next-hop-self received-vpnv6-routes

Change Scope

  • Adding leaf allocate-vpn-label-received-paths to specify if the allocation of locally computed VPN label is enabled for received VPN paths for L3VPN IPv[46] unicast address families.

The rendered network-instance tree looks like:

pyang -f tree -p release/models/*/* --tree-path=/network-instances/network-instance/protocols/protocol/bgp/global/afi-safis/afi-safi

module: openconfig-network-instance
  +--rw network-instances
     +--rw network-instance* [name]
        +--rw protocols
           +--rw protocol* [identifier name]
              +--rw bgp
                 +--rw global
                    +--rw afi-safis
                       +--rw afi-safi* [afi-safi-name]
                          +--rw afi-safi-name              -> ../config/afi-safi-name
                          +--rw config
                          |  +--rw afi-safi-name?         identityref
                          |  +--rw enabled?               boolean
                          |  +--rw send-community-type*   oc-bgp-types:community-type
                          +--ro state
                          |  +--ro afi-safi-name?         identityref
                          |  +--ro enabled?               boolean
                          |  +--ro send-community-type*   oc-bgp-types:community-type
                          |  +--ro total-paths?           uint32
                          |  +--ro total-prefixes?        uint32
[...]
                          +--rw l3vpn-ipv4-unicast
                          |  +--rw config
                          |  |  +--rw allocate-vpn-label-received-paths?   boolean
                          |  +--ro state
                          |  |  +--ro allocate-vpn-label-received-paths?   boolean
                          |  +--rw prefix-limit
                          |  |  +--rw config
                          |  |  |  +--rw max-prefixes?            uint32
                          |  |  |  +--rw prevent-teardown?        boolean
                          |  |  |  +--rw warning-threshold-pct?   oc-types:percentage
                          |  |  +--ro state
                          |  |     +--ro max-prefixes?            uint32
                          |  |     +--ro prevent-teardown?        boolean
                          |  |     +--ro warning-threshold-pct?   oc-types:percentage
                          |  |     +--ro prefix-limit-exceeded?   boolean
                          |  +--rw prefix-limit-received
                          |     +--rw config
                          |     |  +--rw max-prefixes?            uint32
                          |     |  +--rw prevent-teardown?        boolean
                          |     |  +--rw warning-threshold-pct?   oc-types:percentage
                          |     +--ro state
                          |        +--ro max-prefixes?            uint32
                          |        +--ro prevent-teardown?        boolean
                          |        +--ro warning-threshold-pct?   oc-types:percentage
                          |        +--ro prefix-limit-exceeded?   boolean
                          +--rw l3vpn-ipv6-unicast
                          |  +--rw config
                          |  |  +--rw allocate-vpn-label-received-paths?   boolean
                          |  +--ro state
                          |  |  +--ro allocate-vpn-label-received-paths?   boolean
                          |  +--rw prefix-limit
                          |  |  +--rw config
                          |  |  |  +--rw max-prefixes?            uint32
                          |  |  |  +--rw prevent-teardown?        boolean
                          |  |  |  +--rw warning-threshold-pct?   oc-types:percentage
                          |  |  +--ro state
                          |  |     +--ro max-prefixes?            uint32
                          |  |     +--ro prevent-teardown?        boolean
                          |  |     +--ro warning-threshold-pct?   oc-types:percentage
                          |  |     +--ro prefix-limit-exceeded?   boolean
                          |  +--rw prefix-limit-received
                          |     +--rw config
                          |     |  +--rw max-prefixes?            uint32
                          |     |  +--rw prevent-teardown?        boolean
                          |     |  +--rw warning-threshold-pct?   oc-types:percentage
                          |     +--ro state
                          |        +--ro max-prefixes?            uint32
                          |        +--ro prevent-teardown?        boolean
                          |        +--ro warning-threshold-pct?   oc-types:percentage
                          |        +--ro prefix-limit-exceeded?   boolean
  • This change is backwards compatible.

@OpenConfigBot
Copy link

OpenConfigBot commented Nov 16, 2023

Major YANG version changes in commit bc2e6ee:

@vall-arista vall-arista marked this pull request as ready for review November 16, 2023 13:51
@vall-arista vall-arista requested a review from a team as a code owner November 16, 2023 13:51
@rolandphung
Copy link
Contributor

@dplore Any chance to look at this?

@dplore dplore self-assigned this Jan 29, 2024
@dplore
Copy link
Member

dplore commented Jan 29, 2024

Hi, please provide references to implementations of this functionality.

@vall-arista vall-arista closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants