Add support for vni-peer-group container #1015

mikewiebe · 2023-12-12T16:59:51Z

Change Scope

The changes introduce operational state properties only.

Deprecate two properties control-plane-vnis and router-mac
- This means the properties will be supported but deprecated and removed in a future OC model release
Add the new container structure vni-peer-group which allows the association between cp-vni-id, egress-vni and router-mac
Keying on both cp-vni and egress-vni allows flexibility for both symmetric and asymmetric use cases. For symmetric VNIs both keys would be set to the same value.
The change is backwards compatible

Tree Structure

        |           +--rw vxlan
        |              +--rw config
        |              |  +--rw description?        string
        |              |  +--rw enabled?            boolean
        |              |  +--rw source-interface?   string
        |              +--ro state
        |              |  +--ro description?        string
        |              |  +--ro enabled?            boolean
        |              |  +--ro source-interface?   string
        |              +--ro endpoint-peers
        |              |  +--ro endpoint-peer* [peer-address]
        |              |     +--ro peer-address      -> ../state/peer-address
        |              |     +--ro state
        |              |     |  +--ro peer-address?         oc-inet:ip-address
        |              |     |  +--ro peer-state?           enumeration
        |              |     |  +--ro uptime?               oc-types:timeticks64
        |              |     |  x--ro control-plane-vnis*   oc-evpn-types:vni-id
        |              |     |  x--ro router-mac?           oc-yang:mac-address
        |              |     +--ro vni-peer-group
        |              |        +--ro vni-peer-group* [cp-vni egress-vni]
        |              |           +--ro cp-vni        -> ../state/cp-vni
        |              |           +--ro egress-vni    -> ../state/egress-vni
        |              |           +--ro state
        |              |              +--ro cp-vni?       oc-evpn-types:vni-id
        |              |              +--ro egress-vni?   oc-evpn-types:vni-id
        |              |              +--ro router-mac?   oc-yang:mac-address
        |              +--ro endpoint-vnis

With new counters included in the output

        |           +--rw vxlan
        |              +--rw config
        |              |  +--rw description?        string
        |              |  +--rw enabled?            boolean
        |              |  +--rw source-interface?   string
        |              +--ro state
        |              |  +--ro description?        string
        |              |  +--ro enabled?            boolean
        |              |  +--ro source-interface?   string
        |              +--ro endpoint-peers
        |              |  +--ro endpoint-peer* [peer-address]
        |              |     +--ro peer-address       -> ../state/peer-address
        |              |     +--ro state
        |              |     |  +--ro peer-address?         oc-inet:ip-address
        |              |     |  +--ro peer-state?           enumeration
        |              |     |  +--ro uptime?               oc-types:timeticks64
        |              |     |  x--ro control-plane-vnis*   oc-evpn-types:vni-id
        |              |     |  x--ro router-mac?           oc-yang:mac-address
        |              |     |  +--ro counters
        |              |     |     +--ro total-encap-pkts?           oc-yang:counter64
        |              |     |     +--ro total-encap-bytes?          oc-yang:counter64
        |              |     |     +--ro bum-encap-pkts?             oc-yang:counter64
        |              |     |     +--ro total-decap-pkts?           oc-yang:counter64
        |              |     |     +--ro total-decap-bytes?          oc-yang:counter64
        |              |     |     +--ro unicast-decap-pkts?         oc-yang:counter64
        |              |     |     +--ro bum-decap-pkts?             oc-yang:counter64
        |              |     |     +--ro bum-decap-multicast-pkts?   oc-yang:counter64
        |              |     |     +--ro bum-decap-ir-pkts?          oc-yang:counter64
        |              |     |     +--ro drop-decap-pkts?            oc-yang:counter64
        |              |     |     +--ro except-decap-pkts?          oc-yang:counter64
        |              |     +--ro vni-peer-groups
        |              |        +--ro vni-peer-group* [cp-vni egress-vni]
        |              |           +--ro cp-vni        -> ../state/cp-vni
        |              |           +--ro egress-vni    -> ../state/egress-vni
        |              |           +--ro state
        |              |              +--ro cp-vni?       oc-evpn-types:vni-id
        |              |              +--ro egress-vni?   oc-evpn-types:vni-id
        |              |              +--ro router-mac?   oc-yang:mac-address
        |              +--ro endpoint-vnis

Platform Implementations

Cisco NXOS: link to documentation

switch# show nve peers control-plane-vni peer-ip 203.1.1.1
Peer       VNI     Learn-Source Gateway-MAC     Peer-type  Egress-VNI SW-BD  State                 
---------  -----   ------------ --------------- ---------- ---------- -----  ----------------------
203.1.1.1  2000003 BGP          f40f.1b6f.f8db   FAB        3000003      3005   peer-vni-add-complete

Nokia: link to documentation
- From the document: VNIs configured in static VXLAN instances are ‟symmetric”, that is, the same ingress and egress VNIs are used for VXLAN packets using that instance. Note that asymmetric VNIs are actually possible in EVPN VXLAN instances.

OpenConfigBot · 2023-12-12T17:01:16Z

No major YANG version changes in commit 897de89

dplore

Looks good, please update the container to be named with plural vni-peer-groups

release/models/network-instance/openconfig-evpn.yang

mikewiebe · 2024-02-01T17:04:30Z

@dplore I did a rebase and updated the name of the container as requested. There was a failure in the pyangbind step that does not seem related to my chanages.

The error states the following: Validator script failed -- infra bug?

mikewiebe · 2024-02-01T17:05:01Z

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages.

The error states the following: Validator script failed -- infra bug?

dplore · 2024-02-02T03:01:37Z

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages.

The error states the following: Validator script failed -- infra bug?

@wenovus apologies, I pinged you for the wrong PR. This is the one where pyangbind check is failing.

wenovus · 2024-02-02T04:37:10Z

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages.
The error states the following: Validator script failed -- infra bug?

@wenovus apologies, I pinged you for the wrong PR. This is the one where pyangbind check is failing.

Hi @mikewiebe this seems like it might be a one-off error (maybe the cloud VM got killed) especially since the main branch is passing for this check. Can you push an empty commit to re-trigger the CI:

 git commit --allow-empty -m "Retrigger CI" && git push

wenovus · 2024-02-05T17:48:39Z

Merging into main branch for pyangbind check fix.

mikewiebe · 2024-02-13T17:42:18Z

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages.
The error states the following: Validator script failed -- infra bug?

@wenovus apologies, I pinged you for the wrong PR. This is the one where pyangbind check is failing.

Hi @mikewiebe this seems like it might be a one-off error (maybe the cloud VM got killed) especially since the main branch is passing for this check. Can you push an empty commit to re-trigger the CI:
 git commit --allow-empty -m "Retrigger CI" && git push

@wenovus, sorry, I was traveling last couple of weeks so just seeing this. I will try this. Thanks!

mikewiebe · 2024-02-21T18:50:48Z

@wenovus tried a rebase and git commit --allow-empty -m "Retrigger CI" && git push but now it's failing on a different step. public-pr (disco-idea-817). There are no details about the failure except a message Needs /gcbrun from a collaborator so unsure how to proceed. Thanks!

wenovus · 2024-02-21T20:26:58Z

/gcbrun

wenovus · 2024-02-21T20:29:01Z

@wenovus tried a rebase and git commit --allow-empty -m "Retrigger CI" && git push but now it's failing on a different step. public-pr (disco-idea-817). There are no details about the failure except a message Needs /gcbrun from a collaborator so unsure how to proceed. Thanks!

Are you able to see the "Needs /gcbrun from a collaborator" comment in the failure summary?

We recently changed the CI to only be runnable by a maintainer, so it's little cumbersome. I'll investigate whether this can be changed.

mikewiebe · 2024-02-23T23:13:58Z

@wenovus tried a rebase and git commit --allow-empty -m "Retrigger CI" && git push but now it's failing on a different step. public-pr (disco-idea-817). There are no details about the failure except a message Needs /gcbrun from a collaborator so unsure how to proceed. Thanks!

Are you able to see the "Needs /gcbrun from a collaborator" comment in the failure summary?

We recently changed the CI to only be runnable by a maintainer, so it's little cumbersome. I'll investigate whether this can be changed.

Ah, ok. Yes I do see the Needs /gcbrun from a collaborator comment.

dplore · 2024-02-24T01:58:22Z

/gcbrun

dplore · 2024-03-12T19:24:32Z

/gcbrun

dplore · 2024-03-13T16:06:42Z

/gcbrun

wenovus · 2024-04-03T18:41:37Z

/gcbrun

dplore

This has been reviewed in previous OC Community meetings, including the most recent April 4th 2024 OC Community meeting without objection.

* Add support for /network-instances/network-instance/connection-points/connection-point/endpoints/endpoint/vxlan/endpoint-peers/vni-peer-groups container * deprecate control-plane-vnis, router-mac

mikewiebe requested a review from a team as a code owner December 12, 2023 16:59

OpenConfigBot added the non-breaking label Dec 12, 2023

mikewiebe force-pushed the evpn-vni-peergroup branch from 81a55c6 to 42d4845 Compare December 20, 2023 17:21

dplore self-assigned this Jan 16, 2024

dplore reviewed Jan 16, 2024

View reviewed changes

release/models/network-instance/openconfig-evpn.yang Outdated Show resolved Hide resolved

mikewiebe force-pushed the evpn-vni-peergroup branch from fc6a90b to fc1f561 Compare February 1, 2024 16:43

dplore closed this Feb 2, 2024

dplore reopened this Feb 2, 2024

mikewiebe force-pushed the evpn-vni-peergroup branch from 350873e to 5592b5a Compare February 21, 2024 18:41

mikewiebe force-pushed the evpn-vni-peergroup branch from 3dfb0c2 to a58871f Compare February 23, 2024 23:13

mikewiebe added 3 commits March 13, 2024 12:04

Add support for vni-peer-group container

e11eaa0

Change containter to vni-peer-groups

bdbe960

Retrigger CI

9dc4975

mikewiebe force-pushed the evpn-vni-peergroup branch from e09bb9e to 9dc4975 Compare March 13, 2024 16:05

Merge branch 'master' into evpn-vni-peergroup

897de89

dplore approved these changes Apr 11, 2024

View reviewed changes

dplore merged commit 4177f94 into openconfig:master Apr 11, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for vni-peer-group container #1015

Add support for vni-peer-group container #1015

mikewiebe commented Dec 12, 2023 •

edited

Loading

OpenConfigBot commented Dec 12, 2023 •

edited

Loading

dplore left a comment

mikewiebe commented Feb 1, 2024

mikewiebe commented Feb 1, 2024

dplore commented Feb 2, 2024

wenovus commented Feb 2, 2024

wenovus commented Feb 5, 2024

mikewiebe commented Feb 13, 2024 •

edited

Loading

mikewiebe commented Feb 21, 2024 •

edited

Loading

wenovus commented Feb 21, 2024

wenovus commented Feb 21, 2024

mikewiebe commented Feb 23, 2024

dplore commented Feb 24, 2024

dplore commented Mar 12, 2024

dplore commented Mar 13, 2024

wenovus commented Apr 3, 2024

dplore left a comment

Add support for vni-peer-group container #1015

Add support for vni-peer-group container #1015

Conversation

mikewiebe commented Dec 12, 2023 • edited Loading

Change Scope

Tree Structure

Platform Implementations

OpenConfigBot commented Dec 12, 2023 • edited Loading

dplore left a comment

Choose a reason for hiding this comment

mikewiebe commented Feb 1, 2024

mikewiebe commented Feb 1, 2024

dplore commented Feb 2, 2024

wenovus commented Feb 2, 2024

wenovus commented Feb 5, 2024

mikewiebe commented Feb 13, 2024 • edited Loading

mikewiebe commented Feb 21, 2024 • edited Loading

wenovus commented Feb 21, 2024

wenovus commented Feb 21, 2024

mikewiebe commented Feb 23, 2024

dplore commented Feb 24, 2024

dplore commented Mar 12, 2024

dplore commented Mar 13, 2024

wenovus commented Apr 3, 2024

dplore left a comment

Choose a reason for hiding this comment

mikewiebe commented Dec 12, 2023 •

edited

Loading

OpenConfigBot commented Dec 12, 2023 •

edited

Loading

mikewiebe commented Feb 13, 2024 •

edited

Loading

mikewiebe commented Feb 21, 2024 •

edited

Loading