Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bytes-sampled field to sflow sampling model #914

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pandeytejas
Copy link

Change Scope

  • release/models/sampling/openconfig-sampling-sflow.yang
    • Added a new field bytes-sampled to indicate an approximate estimate of the total bytes sampled.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pandeytejas pandeytejas requested a review from a team as a code owner July 17, 2023 06:05
@OpenConfigBot
Copy link

OpenConfigBot commented Jul 17, 2023

No major YANG version changes in commit 3881c4a

@dplore
Copy link
Member

dplore commented Aug 1, 2023

Please provide references for implementations. At a glance, I don't see counters for this from a few major implementations, but I might have overlooked their implementation.

@dplore dplore self-assigned this Nov 28, 2023
@dplore
Copy link
Member

dplore commented Nov 28, 2023

@pandeytejas, this looks straightforward enough, but please provide at least two references to existing implementations which support a count of bytes sampled which is required justification to update the OC models per the OC contribution guide.

@dplore
Copy link
Member

dplore commented Jul 16, 2024

@pandeytejas please do fix the miscellaneous checks and add references, I'd like to see this one get merged.

@github-actions github-actions bot removed the Stale label Aug 21, 2024
@github-actions github-actions bot added the Stale label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

None yet

3 participants