Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default final disposition action of policy chain #974

Conversation

rszarecki
Copy link
Contributor

Change Scope

  • Clarification of semantics of default-import-policy,
    default-export-policy leaves.

@rszarecki rszarecki marked this pull request as ready for review October 12, 2023 21:44
@rszarecki rszarecki requested a review from a team as a code owner October 12, 2023 21:44
@rszarecki rszarecki requested a review from dplore October 12, 2023 21:44
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 12, 2023

No major YANG version changes in commit 1c1727a

@OpenConfigBot
Copy link

OpenConfigBot commented Oct 12, 2023

Compatibility Report for commit 0709d8d:
pyangbind@88db69c

@dplore
Copy link
Member

dplore commented Feb 6, 2024

Discussed in Feb 6, 2024 OC Operators meeting. BGP inheritance is defined here:

"This module describes a YANG model for BGP protocol
configuration.It is a limited subset of all of the configuration
parameters available in the variety of vendor implementations,
hence it is expected that it would be augmented with vendor-
specific configuration data as needed. Additional modules or
submodules to handle other aspects of BGP configuration,
including policy, VRFs, VPNs, and additional address families
are also expected.
This model supports the following BGP configuration level
hierarchy:
BGP
|
+-> [ global BGP configuration ]
+-> AFI / SAFI global
+-> peer group
+-> [ peer group config ]
+-> AFI / SAFI [ per-AFI overrides ]
+-> neighbor
+-> [ neighbor config ]
+-> [ optional pointer to peer-group ]
+-> AFI / SAFI [ per-AFI overrides ]
Most BGP features can be configured at multiple levels in the BGP
configuration level hierarchy. The common inheritance model allows
the more specific configuration (e.g. neighbor) to inherit from or
override the less specific configuration (e.g. global).
Leaf present at one level overrides leafs present at higher levels,
whereas leaf not present inherits its value from the leaf present
at the next higher level in the hierarchy.";

I think your explanations are in line with this, but I think we should not redefine / re-explain it here.

The team suggested if you think it helps, you could add a reference in the routing-policy description to the bgp model description.

I will close this for now, since it's been open awhile. If you like to reopen this and change it to a short reference to the BGP model, we can revisit.

@dplore dplore closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants