Configuring send-community per AFI-SAFI at neighbor/peer-group (#969)

[missaesasaya]

This is a continuation of #843, where the wrong grouping was changed

Change Scope

• Allowing send-community to be configured not only per neighbor/peer-group, but also per AFI-SAFI inside neighbor/peerg-group making the configuration more flexible.
• This change is backwards compatible.

Platform Implementations

• Huawei [https://support.huawei.com/enterprise/en/doc/EDOC1100008283/bbae5056/peer-advertise-community]: the peer configuration is done inside the address-family, so the peer-advertise-community configuration is done per peer+afi/safi
• Juniper [https://www.juniper.net/documentation/en_US/junose15.1/topics/reference/command-summary/neighbor-send-community.html]: Configuration mode indicates the config can be done per address-family
• FRR [https://docs.frrouting.org/en/latest/bgp.html]: Then configuration example show send-community parameter is also configured in address-family mode

module: openconfig-network-instance
  +--rw network-instances
     +--rw network-instance* [name]
        +--rw name                              -> ../config/name
        +--rw protocols
           +--rw protocol* [identifier name]
              +--rw identifier          -> ../config/identifier
              +--rw name                -> ../config/name
              +--rw bgp
                 +--rw global
                 |  +--rw afi-safis
                 |     +--rw afi-safi* [afi-safi-name]
                 |        +--rw afi-safi-name              -> ../config/afi-safi-name
                 |        +--rw config
                 |        |  +--rw afi-safi-name?         identityref
                 |        |  +--rw enabled?               boolean
                 |        |  +--rw send-community-type   oc-bgp-types:community-type
                 |        +--ro state
                 |           +--ro afi-safi-name?         identityref
                 |           +--ro enabled?               boolean
                 |           +--ro send-community-type   oc-bgp-types:community-type
                 |           +--ro total-paths?           uint32
                 |           +--ro total-prefixes?        uint32
                 +--rw neighbors
                 |  +--rw neighbor* [neighbor-address]
                 |     +--rw neighbor-address      -> ../config/neighbor-address
                 |     +--rw config
                 |     |  +--rw peer-group?            -> ../../../../peer-groups/peer-group/peer-group-name
                 |     |  +--rw ...
                 |     |  **+--rw send-community-type*   oc-bgp-types:community-type**
                 |     +--ro state
                 |     |  +--ro peer-group?                   -> ../../../../peer-groups/peer-group/peer-group-name
                 |     |  +--ro ...
                 |     |  **+--ro send-community-type*          oc-bgp-types:community-type**
                 |     +--rw afi-safis
                 |        +--rw afi-safi* [afi-safi-name]
                 |           +--rw afi-safi-name           -> ../config/afi-safi-name
                 |           +--rw config
                 |           |  +--rw afi-safi-name?         identityref
                 |           |  +--rw enabled?               boolean
                 |           |  **+--rw send-community-type*   oc-bgp-types:community-type**   <-- NEW LEAF-LIST
                 |           +--ro state
                 |              +--ro afi-safi-name?         identityref
                 |              +--ro enabled?               boolean
                 |              **+--ro send-community-type*   oc-bgp-types:community-type**   <-- NEW LEAF-LIST
                 |              +--ro active?                boolean
                 +--rw peer-groups
                    +--rw peer-group* [peer-group-name]
                       +--rw peer-group-name       -> ../config/peer-group-name
                       +--rw config
                       |  +--rw peer-group-name?       string
                       |  +--rw ...
                       |  **+--rw send-community-type*   oc-bgp-types:community-type**
                       +--ro state
                       |  +--ro peer-group-name?       string
                       |  +--ro ...
                       |  **+--ro send-community-type*   oc-bgp-types:community-type**
                       +--rw afi-safis
                          +--rw afi-safi* [afi-safi-name]
                             +--rw afi-safi-name           -> ../config/afi-safi-name
                             +--rw config
                             |  +--rw afi-safi-name?         identityref
                             |  +--rw enabled?               boolean
                             |  **+--rw send-community-type*   oc-bgp-types:community-type**   <-- NEW LEAF-LIST
                             +--ro state
                                +--ro afi-safi-name?         identityref
                                +--ro enabled?               boolean
                                **+--ro send-community-type*   oc-bgp-types:community-type**   <-- NEW LEAF-LIST

[OpenConfigBot]

No major YANG version changes in commit bba2375

[OpenConfigBot]

Compatibility Report for commit bb975e9:
⛔ pyangbind@1c28486

[dplore]

Will review on Oct 17, 2023 OC Operators meeting

[missaesasaya]

Any updates from the Operators meeting?

[dplore]

This didn't make the OC Operators review on Oct 17, 2023. We will review at the OC Community meeting on Nov 2, 2023 08:00 PST

[missaesasaya]

As agreed, I added the deprecated status to the leaf-list added by mistake and updated the revisions.

[dplore]

Hi @missaesasaya , please update the PR description with a rendering of the OC tree to make this faster to review, thank you. (using pyang for example)

[missaesasaya]

Hi @missaesasaya , please update the PR description with a rendering of the OC tree to make this faster to review, thank you. (using pyang for example)

Done. Please let me know if this is sufficient.

[dplore]

We've asserted that the hierarchy should be "Global -> PeerGroup -> Neighbor" and the most specific configuration has precedence.

…

On Wed, Dec 27, 2023 at 1:50 AM Missae W. Sasaya ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In release/models/bgp/openconfig-bgp-common-multiprotocol.yang <#976 (comment)>: > + status deprecated; description - "Specify which types of community should be sent to the + "This leaf has been deprecated because it was added by mistake. + Specify which types of community should be sent to the We currently have this leaf for neighbors/peers. If we keep this for global afi/safi, won't there be a conflict if we have different values? We would have two configurations that have no hierarchical relationship. It is different with the peer+afi/safi configuration where it is clear that the more specific configuration has precedence. — Reply to this email directly, view it on GitHub <#976 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMCGMZMIF4B6JMZ5USTUJLYLPVOHAVCNFSM6AAAAAA57BQS6CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJWHE3DSMZZG4> . You are receiving this because you were assigned.Message ID: ***@***.***>

[missaesasaya]

We've asserted that the hierarchy should be "Global -> PeerGroup -> Neighbor" and the most specific configuration has precedence.

Yes, but in this case, the configuration is not global, it is per afi/safi

[missaesasaya]

We've asserted that the hierarchy should be "Global -> PeerGroup -> Neighbor" and the most specific configuration has precedence.

@dplore Change done

[dplore]

This will merge on Jan 19, 2024