-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isis policy metric type leafs fixed for action and condition #989
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Major YANG version changes in commit b8106ce: |
5f785b6
to
e6cd8b2
Compare
@dplore why is the breaking changes check failing? I tried to update the major version so the release is 1.0 |
Sorry about this, the test cases for the script were incorrect. fix at openconfig/models-ci#94 |
After #1003 is merged into the master branch, a sync from master should fix it. |
Thanks for the updates @awebsters .
|
Added rendering of openconfig-routing-policy with isis augmentations |
@dplore any update on this |
@dplore have you had a chance to view this again? |
I plan to re-review by end of month and target to include this change in OC release 3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM. Last call for comments. This will merge on Dec 26th.
…fig#989) * isis policy metric type leafs fixed for action and condition --------- Co-authored-by: Wen Bo Li <[email protected]>
Change Scope
2 changes:
set-metric-type leaf under is-is policy condition.
This field was added in #863 but is named incorrectly. As seen in the implementation examples in that PR, the leaves shouldn't be prefixed with the word 'set' because its meant to be matching on metric-type. We made the change so the leaf's name is match-route-type.
set-metric-type leaf under is-is policy action
Was depreciated in #841 in favor of 'set-metric-style-type' leaf. However, this change depreciated a leaf that was supposed to have type metric-type for a new leaf of type metric-style (metric style is still valid in the actions branch). We now do not support a metric-type leaf under the action. We create a new one called set-route-type.
We called these new leaves *-route-type so the leaves under condition and action could match in the naming convention without breaking the backward compatibility of the actions branch.
Platform Implementations
The new naming convention of set/match-route-type aligns with a proposed standard RFC 9067
Resulting Tree