Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify backplane facing capacity - consumed capacity #990

Closed
wants to merge 4 commits into from

Conversation

rohit-rp
Copy link

@rohit-rp rohit-rp commented Nov 3, 2023

Change Scope

Clarifying /components/component/integrated-circuit/backplane-facing-capacity/state/consumed-capacity to refer to the capacity consumed by traffic on the front panel ports

Clarifying /components/component/integrated-circuit/backplane-facing-capacity/state/total
and /components/component/integrated-circuit/backplane-facing-capacity/state/total-operational-capacity to refer to the connection between INTEGRATED_CIRCUIT and FABRIC component identities.
The word link can be confused with an interface or port, when it actually means a fabric link or SerDes link

Platform Implementations

total and total-operational-capacity:
The word "link" can be confused with an interface or port, when it actually means a "fabric link"

consumed-capacity:
Causes confusion. It Is not the capacity that is consumed by the front-panel ports being "operationally up" but by the amount of traffic on the interface (in bits per second)
@rohit-rp rohit-rp requested a review from a team as a code owner November 3, 2023 15:32
Copy link

google-cla bot commented Nov 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OpenConfigBot
Copy link

OpenConfigBot commented Nov 3, 2023

Major YANG version changes in commit e27e52a:

oc-ext:telemetry-on-change;
}

leaf consumed-capacity {
type uint64;
units "bits per second";
description
"Backplane-facing capacity that is consumed by front-panel ports that are connected
to the integrated circuit and are operationally up.";
"Backplane-facing capacity that is consumed by the traffic on front-panel ports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not strictly the traffic only those ports, right? If I have 400G front-panel port this consumes 400G, not whatever the traffic load on that port is at this exact moment in time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rohit and I discussed an issue brought up by implementors of this model. The purpose of this PR is to explore and clarify what the intent of this leaf is. The modern, modular form factor packet based devices that I am familiar with only consume fabric capacity based on packets or cells sent over the fabric. Bringing a front panel port up or down does not change the capacity that is in consumed between the INTEGRATED_CIRCUIT (IC) and the FABRIC.

@rohit-rp I added a Juniper reference to the PR description. Can you look for better references for Arista and Cisco? I could not find information regarding 'consumed capacity' of IC to FABRIC in the references provided.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Nokia SRLinux we provide this utilization data per direction (ingress/egress): https://documentation.nokia.com/srlinux/23-10/books/data-model-reference/srl_nokia-platform_0.html#d6179

@dplore
Copy link
Member

dplore commented Jan 17, 2024

After further review of the operational use cases for this leaf, it seems the desire is to get the 'subscription ratio' on a LINECARD between the capacity of enabled front panel ports and the capacity of the LINECARD connection to the FABRIC.

So rather than using the word 'consumed', we should update this to use 'ratio of a LINECARD front panel interface bandwidth capacity to the bandwidth capacity of the connection between the LINECARD and FABRIC'.

@dplore dplore self-assigned this Jan 29, 2024
@dplore dplore changed the title Update openconfig-platform-integrated-circuit.yang Clarify backplane facing capacity - consumed capacity Jan 30, 2024
@dplore
Copy link
Member

dplore commented Jun 4, 2024

@rohit-rp please address comments and we can move this one forward

@github-actions github-actions bot added the Stale label Dec 2, 2024
@github-actions github-actions bot closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

5 participants