[1.2] libc/int/userns: add build tag to C file #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes k3s cross-compilation on Windows, broken by commit 1912d59 ("*: actually support joining a userns with a new container"). [@kolyshkin: commit message] Fixes: 1912d59 Signed-off-by: Brad Davidson <[email protected]> Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit ccb589b) Signed-off-by: Kir Kolyshkin <[email protected]>
xximwon
approved these changes
Feb 7, 2025
xximwon
approved these changes
Feb 7, 2025
cyphar
approved these changes
Feb 7, 2025
AkihiroSuda
approved these changes
Feb 7, 2025
|
Ended up finding out it's not needed for a variety of reasons (see k3s-io/k3s#11722 (comment) for details). Won't hurt either, so let's consider this change a NOP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4616 to release-1.2.
This fixes k3s cross-compilation on Windows, broken by commit 1912d59 ("*: actually support joining a userns with a new container").
[@kolyshkin: commit message]
Fixes: 1912d59
(cherry picked from commit ccb589b)