Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.5 #4626

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Release v1.2.5 #4626

merged 3 commits into from
Feb 14, 2025

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Feb 12, 2025

Copy-paste of release notes is below.

This also includes a cherry-pick of #4629.


1.2.5 - 2025-02-13

Мороз и солнце; день чудесный!

Fixed

Changed

@kolyshkin kolyshkin added this to the 1.2.5 milestone Feb 12, 2025
@kolyshkin kolyshkin requested a review from cyphar February 12, 2025 16:55
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar
Copy link
Member

cyphar commented Feb 13, 2025

Hmmm, the release signing script doesn't work on my machine anymore without #4629. No idea what changed recently...

I'll push a cherry-pick into this PR so we don't have to review a separate PR for a simple packaging-script-only change.

EDIT: Hmm, I can't seem to push to your branch directly even though the PR is marked as allowing edit access...

% git push kolyshkin 1.2.5 --force
ERROR: Permission to kolyshkin/runc.git denied to cyphar.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
% git remote -v | grep kolyshkin
kolyshkin       [email protected]:kolyshkin/runc.git (fetch)
kolyshkin       [email protected]:kolyshkin/runc.git (push)

@lifubang
Copy link
Member

How about including this one(#4632) according to a security reason.

Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin force-pushed the 1.2.5 branch 3 times, most recently from bcf0898 to 66b6954 Compare February 13, 2025 22:55
cyphar and others added 3 commits February 13, 2025 14:58
On my machine, the --recv-keys steps to get upstream keys started
producing errors recently, and even setting a default keyserver in the
global gpg configuration doesn't seem to help:

  + gpg --homedir=/tmp/runc-sign-tmpkeyring.qm0IP6
        --no-default-keyring --keyring=seccomp.keyring
        --recv-keys 0x47A68FCE37C7D7024FD65E11356CE62C2B524099
  gpg: keybox '/tmp/runc-sign-tmpkeyring.qm0IP6/seccomp.keyring' created
  gpg: keyserver receive failed: No keyserver available

So just explicitly specify a reputable keyserver. Ideally we would use
an .onion-address keyserver to avoid potential targeted attacks but not
everybody runs a Tor proxy on their machine.

Signed-off-by: Aleksa Sarai <[email protected]>
(cherry picked from commit 26cfe14)
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
@cyphar cyphar merged commit 300d35b into opencontainers:release-1.2 Feb 14, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants