Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 11469: fix(backend): Synced ScheduledWorkflow CRs on apiserver startup #124

Merged

Conversation

hbelmiro
Copy link

@hbelmiro hbelmiro commented Jan 9, 2025

Cherry-pick of: kubeflow#11469

This PR has to be merged after:

Checklist:

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 1 commits between 2969fcac9a590bc26c59ca95a9ed8eacc514b6a3...4a17f38af5b0e34d3cc7f263a45ead46fb7f6e97

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 1 commits between 2969fcac9a590bc26c59ca95a9ed8eacc514b6a3...b402354cc2b39a6ba74c89a291ab759e2e1d59d7

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-124
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-124
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-124
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-124
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-124
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-124

@hbelmiro hbelmiro marked this pull request as ready for review January 14, 2025 19:51
@openshift-ci openshift-ci bot requested review from gmfrasca and rimolive January 14, 2025 19:51
@VaniHaripriya
Copy link

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Jan 16, 2025
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 1 commits between f1b7367b30095877b3503fac552b215db87258ca...8ab8dae806e55e00b9e8c3d2c1f0244cb1636903

Copy link

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-124
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-124
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-124
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-124
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-124
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-124

@openshift-merge-bot openshift-merge-bot bot merged commit d9ec34e into opendatahub-io:master Jan 16, 2025
5 checks passed
@hbelmiro hbelmiro deleted the cherry-pick-11469 branch January 16, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants