Add additional step to pipeline to generate a metrics report #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
reviewed
Dec 18, 2024
MichaelClifford
force-pushed
the
metrics
branch
3 times, most recently
from
cad432f to
8a6be72
Compare
|
@tumido updated the PR to use PVC's instead of interim output artifacts. |
MichaelClifford
force-pushed
the
metrics
branch
from
8a6be72 to
efe0ed0
Compare
tumido
reviewed
Jan 6, 2025
MichaelClifford
force-pushed
the
metrics
branch
from
efe0ed0 to
70fe60c
Compare
tumido
reviewed
Jan 7, 2025
leseb
reviewed
Jan 7, 2025
MichaelClifford
force-pushed
the
metrics
branch
from
1f4bd14 to
06ea8aa
Compare
tumido
reviewed
Jan 8, 2025
leseb
reviewed
Jan 8, 2025
MichaelClifford
force-pushed
the
metrics
branch
3 times, most recently
from
2508289 to
898b6f7
Compare
tumido
reviewed
Jan 13, 2025
MichaelClifford
force-pushed
the
metrics
branch
3 times, most recently
from
6259904 to
9458ad4
Compare
tumido
requested changes
Jan 20, 2025
Signed-off-by: Michael Clifford <[email protected]>
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
force-pushed
the
metrics
branch
3 times, most recently
from
e8904e4 to
665b632
Compare
tumido
requested changes
Jan 22, 2025
leseb
reviewed
Jan 22, 2025
leseb
approved these changes
Jan 22, 2025
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
force-pushed
the
metrics
branch
from
665b632 to
eab37c5
Compare
tumido
requested changes
Jan 23, 2025
Comment on lines
+467
to
+469
| output_mmlu_branch_task, | ||
| output_mt_bench_branch_task, | ||
| generate_metrics_report_task, |
There was a problem hiding this comment.
I'm sorry to be so stubborn here. 😄 I still think this is not a correct list of dependencies. I think it should be:
Suggested change
| output_mmlu_branch_task, | |
| output_mt_bench_branch_task, | |
| generate_metrics_report_task, | |
| output_model_task, | |
| output_mt_bench_task, | |
| output_mmlu_branch_task, | |
| output_mt_bench_branch_task, | |
| generate_metrics_report_task, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new step to the end of the pipeline,
generate_metrics_report_op. The purpose of this step is to create a number of kfpMerticartifacts that can help users easily compare the performance between different runs using thecompare runsfeature of the Data Science Pipeline UI.