refactor: remove phase mocking and faked packages #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Coufal <[email protected]>
tumido
requested review from
MichaelClifford and
leseb
and removed request for
MichaelClifford
leseb
reviewed
Jan 7, 2025
There was a problem hiding this comment.
I think the removal of the mock/faked package and the relocation of various files for eval could have been handled as separate changes. Having both makes it harder to review but since it's there I don't want to block it, let's try to isolate the changes into different PRs next time :). Thanks!
I just left two small questions otherwise LGTM. Thanks!
leseb
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54
Description
Since we've migrated to PVC data passing and did a lot of other optimizations, there's no use for the mocked phases anymore and nobody is using them. That makes this approach a tech debt which we should clean up.
In addition to that, I've reviewed PyLint exceptions and cleaned up some duplicate imports within individual components.