Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DeploymentMode to InferenceService and InferenceGraph status #479

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

VedantMahabaleshwarkar
Copy link

Cherry-picking changes from kserve#4194 to ODH to be included in RHOAI 2.18

Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all good, but the go.sum file that should not be changed.
Revert that one, and we can merge.

Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
Copy link

openshift-ci bot commented Feb 3, 2025

@VedantMahabaleshwarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-fast 1a129bd link true /test e2e-fast
ci/prow/e2e-slow 1a129bd link true /test e2e-slow
ci/prow/e2e-raw 1a129bd link true /test e2e-raw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Jooho Jooho merged commit eb73ea1 into opendatahub-io:master Feb 3, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants