Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OpenShift Route creation for InferenceGraphs #481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

InferenceGraphs doesn't have any ingress reconciler. Despite that, in ODH we need a mechanism to expose InferenceGraphs. This implements exposing InferenceGraphs on OpenShift using Routes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://issues.redhat.com/browse/RHOAIENG-17831

Type of changes
Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing:

  • Create InferenceGraph in Raw mode. Then, check that a route is created and accessible.
    • Delete the created Route. Check that the controller restores it.
    • Delete the InferenceGraph. Check that the Route is deleted.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • [ x Has code been commented, particularly in hard-to-understand areas?
  • [N/A] Have you made corresponding changes to the documentation?

InferenceGraphs doesn't have any ingress reconciler. Despite that, in ODH we need a mechanism to expose InferenceGraphs. This implements exposing InferenceGraphs on OpenShift using Routes.

Signed-off-by: Edgar Hernández <[email protected]>
@israel-hdez israel-hdez requested a review from Jooho January 31, 2025 23:35
Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 1, 2025

@israel-hdez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-fast ec7272e link true /test e2e-fast
ci/prow/e2e-slow ec7272e link true /test e2e-slow
ci/prow/e2e-raw ec7272e link true /test e2e-raw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Jooho
Copy link

Jooho commented Feb 5, 2025

This looks good to me. the code does not impact existing code because it is additional logic to create a route. so I don't think we need e2e test for this.
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New/Backlog
Development

Successfully merging this pull request may close these issues.

2 participants