Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-15743: fix(odh-nbc): trim ca-bundle certData to avoid logging scary messages #455

Merged

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 14, 2024

https://issues.redhat.com/browse/RHOAIENG-15743

Description

After opendatahub-io/opendatahub-operator#1339, operator is adding '\n' unconditionally to the odh cert bundle, and that is breaking our == "" checks. Trim the certData and restore balance in the universe.

See the equivalent fix in pipelines

How Has This Been Tested?

  • quay.io/opendatahub/odh-notebook-controller:pr-455

Put image into odh-notebook-controller deployment and see how

{"level":"info","ts":"2024-11-15T19:10:16Z","logger":"controllers.Notebook","msg":"Invalid certificate format","notebook":"elyra","namespace":"jdanek2","configMap":"odh-trusted-ca-bundle","certFile":"odh-ca-bundle.crt"}

disappears when thecustomCABundle in DSCi is ''.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and dibryant November 14, 2024 19:27
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jiridanek
Copy link
Member Author

I'll prepare this for eventual merging to rhds/master; looks like there is still time to get this to 2.16 and the log message is really annoying.

@jiridanek
Copy link
Member Author

/approve

Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a3bf3df into opendatahub-io:main Nov 18, 2024
12 checks passed
@jiridanek jiridanek deleted the jd_trim_dert_data branch November 18, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants