Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.9-branch] RHOAIENG-8390: feat(odh-nbc): search for imagestreams only in the namespace the controller runs in #474

Closed
wants to merge 2 commits into from
Closed

[v1.9-branch] RHOAIENG-8390: feat(odh-nbc): search for imagestreams only in the namespace the controller runs in #474

wants to merge 2 commits into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #375

/assign jiridanek

shalberd and others added 2 commits November 27, 2024 15:31
@shalberd
RHOAIENG-8390: feat(odh-nbc): search for imagestreams only in the nam…
f22f6e6 
…espace the controller runs in (opendatahub-io#375) * [Fix] search for imagestreams only in the namespace the controller runs in.

- Take namespace that the controller runs in
- Log that dynamically-determined namespace once at startup.
- Use hard-coded namespace for unit tests.
@jiridanek
review suggestion, fix comment in tests
9b4dbdb
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 27, 2024
Merged
3 tasks
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 27, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

we don't cherrypick like this anymore, it is a stale command that was set on the PR long time ago

@jiridanek jiridanek closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caponetto caponetto Awaiting requested review from caponetto

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees

@jiridanek jiridanek

Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @jiridanek @shalberd