Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest to support generic route #233

Closed

Conversation

vaibhavjainwiz
Copy link
Member

Motivation

With opendatahub-io/odh-model-controller#59 we had implemented a hot fix by exposing predictor URL directly to user but to provide proper fix we need to implement a generic openshift route for kserve inference service.

Now with opendatahub-io/odh-model-controller#84 we had implemented the generic route functionality so I am adding roles which are required to support generic route functionality.

Modifications

Result

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

@openshift-ci openshift-ci bot requested review from danielezonca and Jooho October 12, 2023 11:23
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaibhavjainwiz
Copy link
Member Author

closing it because manifest are now moved inside individual repos. These changes are for odh-model-controller and its corresponding msnifests are already updated in odh-model-controller repo.

@vaibhavjainwiz vaibhavjainwiz deleted the generic-route branch January 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose generic OpenShift routes for KServe InferenceServices
1 participant