Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-18459: chore(tests/containers/workbenches): listen on single-stack IPv6 #866

Merged

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jan 25, 2025

Description

This is an initial version of the test. Implementation for macOS will come later, for now test only run on Linux.

It also introduces the TestFrame utility class into the test suite.

How Has This Been Tested?

Works on Linux

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from harshad16 and jstourac January 25, 2025 21:46
@openshift-ci openshift-ci bot added the size/m label Jan 25, 2025
@jiridanek jiridanek force-pushed the jd_initial_ipv6_no_macos branch from 89ff07d to 408c8b5 Compare January 25, 2025 21:48
@openshift-ci openshift-ci bot added size/m and removed size/m labels Jan 25, 2025
@jiridanek jiridanek force-pushed the jd_initial_ipv6_no_macos branch from 408c8b5 to 28c2e98 Compare January 25, 2025 22:16
@jiridanek jiridanek force-pushed the jd_initial_ipv6_no_macos branch from c15a364 to 0585b38 Compare January 26, 2025 19:43
@openshift-ci openshift-ci bot added size/l and removed size/l labels Jan 26, 2025
…-stack ipv6

This is an initial version of the test.
It introduces the TestFrame utility class into the test suite.
Implementation for macOS will come later, for now test only run on Linux.
@jiridanek jiridanek force-pushed the jd_initial_ipv6_no_macos branch from d3b3a6d to 4e9b8ff Compare January 26, 2025 21:23
@openshift-ci openshift-ci bot added size/l and removed size/l labels Jan 26, 2025
@jstourac
Copy link
Member

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 131bd61 into opendatahub-io:main Jan 27, 2025
7 checks passed
@jiridanek jiridanek deleted the jd_initial_ipv6_no_macos branch January 27, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/l tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants