RHOAIENG-11156: chore(tests/containers/jupyterlab): check that the JuyterLab index.html contains the spinner code #874
Conversation
| response = requests.get(f"http://{host_ip}:{host_port}/notebook/opendatahub/jovyan") | ||
| assert response.status_code == 200 | ||
| assert "text/html" in response.headers["content-type"] | ||
| assert 'class="pf-v6-c-spinner"' in response.text |
There was a problem hiding this comment.
too pitty we didn't put some testid attribute to this our extra element against which we could check here...
There was a problem hiding this comment.
that's a good-first-issue for interns
|
Based on the linked CI you provided - shall I understand it that the test is expected to pass in all of our Jupyter images despite the [comment in this jira|https://issues.redhat.com/browse/RHOAIENG-11156?focusedId=26491161&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-26491161]? Based on the description in https://issues.redhat.com/browse/RHOAIENG-18915 - shall I understand it so that the fix worked and we simply didn't propagate it fully to the current 2.17 release, is that my assumption correct? |
When I ran this on the image from our 2.17 release, the test failed for me the pytest command above gives me |
This means yes to my question/assumption, correct? |
…pyterLab index.html contains the spinner code
jiridanek
force-pushed
the
jd_spinner_check
branch
from
b353f1a to
ed8f99a
Compare
Yes, at least, that's also how I understand it. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b7e6497
into
opendatahub-io:refactor/konflux-migration
https://issues.redhat.com/browse/RHOAIENG-11156
Description
How Has This Been Tested?
Merge criteria: