Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(tests/containers): detect socket for ryuk's use with rootless podman on macOS #884

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 4, 2025

Description

We should support rootless Podman on macOS.

The disadvantage is that it becomes necessary to stop pretending we work with Docker. While it is possible to send raw api query to libpod/info, it's best to just import the podman library and use the .info() method.

Either case, the result is untyped dict, so pydantic to the rescue.

  • consider adding more logging for the macOS case

How Has This Been Tested?

Followed steps in README.md to run some tests.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put one comment, otherwise LGTM. I can't test it myself, but I trust you it works as expected.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the size/xl label Feb 5, 2025
@openshift-ci openshift-ci bot added the size/xl label Feb 5, 2025
@jiridanek
Copy link
Member Author

Thanks for the checks. GHA tries linux with rootful podman, and I now also tried lima to check linux rootless podman. Should be good to to.
/approve

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/xl and removed size/xl labels Feb 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 09d0130 into opendatahub-io:refactor/konflux-migration Feb 5, 2025
6 checks passed
@jiridanek jiridanek deleted the jd_disable_ryuk branch February 5, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants