-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: chore(tests/containers): detect socket for ryuk's use with rootless podman on macOS #884
NO-JIRA: chore(tests/containers): detect socket for ryuk's use with rootless podman on macOS #884
Conversation
8ec9a96
to
3dba71f
Compare
3dba71f
to
3c45d7a
Compare
3c45d7a
to
80c9268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put one comment, otherwise LGTM. I can't test it myself, but I trust you it works as expected.
/lgtm
80c9268
to
33083c3
Compare
New changes are detected. LGTM label has been removed. |
Thanks for the checks. GHA tries linux with rootful podman, and I now also tried lima to check linux rootless podman. Should be good to to. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ootless podman on macOS
33083c3
to
89dcb89
Compare
09d0130
into
opendatahub-io:refactor/konflux-migration
Description
We should support rootless Podman on macOS.
The disadvantage is that it becomes necessary to stop pretending we work with Docker. While it is possible to send raw api query to
libpod/info
, it's best to just import the podman library and use the.info()
method.Either case, the result is untyped dict, so pydantic to the rescue.
How Has This Been Tested?
Followed steps in README.md to run some tests.
https://github.com/jiridanek/notebooks/actions/runs/13139973981https://github.com/jiridanek/notebooks/actions/runs/13152311827Merge criteria: