-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Mesh]: handle istio proxy events #1937
[Service Mesh]: handle istio proxy events #1937
Conversation
@andrewballantyne could you take a look at this when you have some bandwidth? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this feature has a path to RHOAI, I need you to clean up some of this (which I can give you direction on). Waiting for your response on slack or here.
/hold
For now let's just hold up this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang -- these kind of PRs remind me all the tech debt we need to do to get away from the Jupyter Tile 😞 -- not your problem though. Can you just update the code to be less open-ended and then we can go ahead with this (do it in both files please).
/approve
Just made the code changes and we can lgtm this.
/unhold It's not awesome, but there is little to do here other than get started on that refactor to get rid of the custom Jupyter tile logic (which is really in most cases duplicate of our Projects view) |
Please do to both areas @cam-garrison & squash commits into a single commit always. Rebase your PR if you need to, never merge to save you the headache when squashing. Let me know if you have any questions about this. |
Co-authored-by: Andrew Ballantyne <[email protected]>
8b1becd
to
6e509a7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
51d5cfb
into
opendatahub-io:f/ossm
Closes: #1935
Description
This PR adds displaying the various event states when pulling the istio-proxy container. Before this PR, the percentage is not updated for the different stages of pulling the istio-proxy container as it was for the oauth-proxy container.
This is implemented by adding a function wrapping around the switch statement previously used for oauth-proxy, and now can be used for either
oauth
oristio
proxy depending on which is being pulled/started. The helper functioncapitalizeFirstLetter
is used to maintain the same messages as before (in terms of capitalizing Oauth vs oauth).Note: the 'pulling istio proxy' message should not appear - this proxy sidecar will be pulled for the dashboard's sidecars as well so.
How Has This Been Tested?
Tested by installing operator v2 with service mesh: see opendatahub-io/opendatahub-operator#605. Then, tested creating notebooks from the jupyter tile and from a data science project to ensure that the "Istio proxy container started" message is shown last. Also, tested with
ODHDashboardConfig.disableServiceMesh=true
in both cases to see that Oauth related event messages are still shown.Test Impact
I am not sure where to add tests for this kind of a change - please point me in the right direction if testing would be needed for this PR!
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main