Skip to content

Commit

Permalink
chore: gives nbPath better name
Browse files Browse the repository at this point in the history
  • Loading branch information
bartoszmajsak committed Oct 6, 2023
1 parent 5447f1a commit 7ed09d5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions components/workbenches/workbenches.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,24 +127,24 @@ func (w *Workbenches) ReconcileComponent(cli client.Client, owner metav1.Object,
}
}

nbPath := notebookControllerPath
actualNbCtrlPath := notebookControllerPath
shouldConfigureServiceMesh, err := deploy.ShouldConfigureServiceMesh(cli, dscispec)
if err != nil {
return err
}
if shouldConfigureServiceMesh {
nbPath = notebookControllerServiceMeshPath
actualNbCtrlPath = notebookControllerServiceMeshPath
}

if err := deploy.DeployManifestsFromPath(cli, owner, nbPath, dscispec.ApplicationsNamespace, ComponentName, enabled); err != nil {
if err := deploy.DeployManifestsFromPath(cli, owner, actualNbCtrlPath, dscispec.ApplicationsNamespace, ComponentName, enabled); err != nil {
return err
}

// Update image parameters for nbc in downstream
if enabled {
if dscispec.DevFlags.ManifestsUri == "" && len(w.DevFlags.Manifests) == 0 {
if platform == deploy.ManagedRhods || platform == deploy.SelfManagedRhods {
if err := deploy.ApplyImageParams(nbPath, imageParamMap); err != nil {
if err := deploy.ApplyImageParams(actualNbCtrlPath, imageParamMap); err != nil {
return err
}
}
Expand Down

0 comments on commit 7ed09d5

Please sign in to comment.