Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGOUT_REDIRECT_URL to be used for logout redirection #28765

Closed
wants to merge 1 commit into from

Conversation

asadiqbal08
Copy link
Contributor

Description

If redirect_url is not specified in the logout URL (/logout) then the user is by default redirected to edX's dashboard (/dashboard). Introduced a new variable named LOGOUT_REDIRECT_URL which can be used as default redirection-url instead of dashboard.

Supporting information

issue-271

Deadline

Aim to get this merged before October 9

@openedx-webhooks
Copy link

Thanks for the pull request, @asadiqbal08! I've created OSPR-6051 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Sep 16, 2021
@pdpinch
Copy link
Contributor

pdpinch commented Sep 16, 2021

two quick things @asadiqbal08

  1. Please change the commit message to follow OEP-0051: Conventional Commits
  2. Please add annotations for the feature toggle, following OEP-17: Feature Toggles

I don't think this is quite following the best practices for feature toggles, but I would need to find a reference on that.

@natabene
Copy link
Contributor

@asadiqbal08 Thank you for your contribution. Please let me know once it is ready for our review.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Sep 17, 2021
@asadiqbal08 asadiqbal08 force-pushed the asadiqbal08/issue-fix-271 branch from b7c6cef to 1378d6a Compare September 17, 2021 07:12
@pdpinch
Copy link
Contributor

pdpinch commented Sep 17, 2021

Ok, technically this isn't a feature toggle, but the recommendations for documenting settings are similar: https://code-annotations.readthedocs.io/en/latest/contrib/how_to/documenting_django_settings.html

@asadiqbal08 asadiqbal08 force-pushed the asadiqbal08/issue-fix-271 branch from 0dc4332 to a720d61 Compare September 17, 2021 12:46
@asadiqbal08
Copy link
Contributor Author

@pdpinch I addressed your feedback, anything else ?

@asadiqbal08
Copy link
Contributor Author

@natabene Can you please initiate the review process ?

@natabene
Copy link
Contributor

@asadiqbal08 Sure, I will ask for this to be reviewed.

@natabene natabene removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 21, 2021
@pdpinch
Copy link
Contributor

pdpinch commented Oct 15, 2021

jenkins run all

@pdpinch
Copy link
Contributor

pdpinch commented Oct 15, 2021

@asadiqbal08 how do I test this in devstack? Where should I set the value for LOGOUT_REDIRECT_URL?

@pdpinch
Copy link
Contributor

pdpinch commented Oct 15, 2021

I think this needs a rebase, in order to pass tests.

@asadiqbal08 asadiqbal08 force-pushed the asadiqbal08/issue-fix-271 branch from a720d61 to 0f94d24 Compare October 18, 2021 08:08
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

Copy link
Contributor

@waheedahmed waheedahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @asadiqbal08, thank you for your contribution!

👍 once all builds are green.

@natabene
Copy link
Contributor

@asadiqbal08 Please try rebasing so that remaining checks run.

If redirect_url is not specified in the logout URL (/logout) then the user is by default redirected to edX's dashboard (/dashboard).
Introduced a new variable named LOGOUT_REDIRECT_URL which can be used as default redirection-url instead of dashboard.
@asadiqbal08 asadiqbal08 force-pushed the asadiqbal08/issue-fix-271 branch from c9852e6 to 1a86301 Compare January 13, 2022 11:25
@natabene
Copy link
Contributor

natabene commented Apr 1, 2022

@asadiqbal08 We have not heard from you in a while, so I will close this request for now. Please feel free to reopen, should you decide to pursue this again.

@natabene natabene closed this Apr 1, 2022
@openedx-webhooks
Copy link

@asadiqbal08 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants