-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0044] Course unit - Edit iframe modal window #35777
feat: [FC-0044] Course unit - Edit iframe modal window #35777
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
b64202e
to
0e6e817
Compare
8a6b032
to
74ac804
Compare
00886d4
to
efccc8a
Compare
efccc8a
to
362e883
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the fact we need so many CSS fixes in cms/static/sass/course-unit-mfe-iframe-bundle.scss
, but I figure this is just part doing business with this code. (I suspect the existing XBlock editors are making bad assumptions about the surrounding styles to begin with.)
I also have no way to test the Hotjar stuff, so we'll just deal with it if issues arise down the line.
And finally, as before I'm not going to block this from merging, but I was able to get more details in the y-scrolling issue identified earlier. When you create a block for the first time and save it, the y position is not changed to find it after loading. This is not observed when you edit a block after it already exists, in which case the scroll happens correctly. If this is confirmed to be a regression, we should fix it in future PRs.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Yes, you are right. Since the styling of different xblocks can be implemented differently (most styles do not rely on Paragon), the course-unit-mfe-iframe-bundle.scss file was created to improve the UI/UX when working with modal editing windows.
Thanks, I remember about it, I will fix it in the next PR |
…to send to edx-submission test: Adjust styles feat: course unit - edit iframe modal window (openedx#35777) Adds logic to support the functionality of editing xblocks via the legacy modal editing window. docs: fixing make docs command. (openedx#36280) * docs: fixing make docs command. fix: import authoring filter from content_authoring instead (openedx#36109) Correctly name authoring subdomain according to DDD docs: https://openedx.atlassian.net/wiki/spaces/AC/pages/663224968/edX+DDD+Bounded+Contexts fix: ADR document update for change from Xqueue to edx-submission
…to send to edx-submission test: Adjust styles feat: course unit - edit iframe modal window (openedx#35777) Adds logic to support the functionality of editing xblocks via the legacy modal editing window. docs: fixing make docs command. (openedx#36280) * docs: fixing make docs command. fix: import authoring filter from content_authoring instead (openedx#36109) Correctly name authoring subdomain according to DDD docs: https://openedx.atlassian.net/wiki/spaces/AC/pages/663224968/edX+DDD+Bounded+Contexts fix: ADR document update for change from Xqueue to edx-submission
🚨 Dependencies:
Description
This PR adds logic to support the functionality of editing xblocks via the legacy modal editing window.
Useful information to include:
Supporting information
The next PR will be adding post messages for the tagging functionality.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.