-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: entity link view and api #36190
feat: entity link view and api #36190
Conversation
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1423fe2
to
55e68a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Working beautifully.
- I tested this using the test instructions from feat: course libraries page [FC-0076] frontend-app-authoring#1641
Also had to run migrations,recreate_upstream_links
andreindex_studio
to get the data ready to test. - I read through the code that's changed since feat: upstream-downstream entity linking [FC-0076] #36111 (ref compare)
-
I checked for accessibility issuesN/A - Includes documentation - code comments
-
User-facing strings are extracted for translationN/A
bec771b
to
41d2b3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I will merge it tomorrow morning
@navinkarkera I have two question before to merge this:
|
@ChrisChV Nice catch! Added. Also, gated this page behind
We have a discussion going on in the issue here: openedx/frontend-app-authoring#1565. Since it depends on UX designs, I'll handle it in a separate task. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description:
Adds api for listing upstream entity links for a given course.
Test instructions: See openedx/frontend-app-authoring#1641
Part of: openedx/frontend-app-authoring#1565
Private-ref: FAL-4006