Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: entity link view and api #36190

Merged

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Jan 29, 2025

Description:

Adds api for listing upstream entity links for a given course.

Test instructions: See openedx/frontend-app-authoring#1641

Part of: openedx/frontend-app-authoring#1565
Private-ref: FAL-4006

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 29, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 29, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@navinkarkera navinkarkera force-pushed the navin/fal-4006/course-libraries-page branch 2 times, most recently from 1423fe2 to 55e68a9 Compare February 10, 2025 04:44
@navinkarkera navinkarkera marked this pull request as ready for review February 10, 2025 12:06
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Working beautifully.

@navinkarkera navinkarkera force-pushed the navin/fal-4006/course-libraries-page branch from bec771b to 41d2b3a Compare February 12, 2025 05:41
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will merge it tomorrow morning

@ChrisChV
Copy link
Contributor

@navinkarkera I have two question before to merge this:

@navinkarkera
Copy link
Contributor Author

Shouldn't we also add the libraries menu to the legacy page?

@ChrisChV Nice catch! Added. Also, gated this page behind libraries_v2_enabled flag.

What should happen when the upstream link is removed? (I had this question after testing

We have a discussion going on in the issue here: openedx/frontend-app-authoring#1565. Since it depends on UX designs, I'll handle it in a separate task.

@ChrisChV ChrisChV enabled auto-merge (squash) February 18, 2025 15:15
@ChrisChV ChrisChV merged commit a1d0826 into openedx:master Feb 18, 2025
48 checks passed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants