fix: ensure unsubscribe event captures user context for logged-out users #36247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhtishamShahid
approved these changes
Feb 17, 2025
muhammadadeeltajamul
approved these changes
Feb 18, 2025
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user unsubscribed from email digests using a browser where they were not logged in, the event tracker (tracker.emit) did not store the user context. As a result, the user_id and username fields were recorded as NULL in the tracking_events_with_metadata table.
This PR fixes the issue by ensuring that, even if the user is not logged in, the event captures and stores the user context from the unsubscribe request. The event payload now always includes user_id and username, preventing data inconsistencies in tracking.
Related ticket
https://2u-internal.atlassian.net/browse/INF-1790
Testing instructions