Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make refund_entitlement pluggable #36248

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

syedsajjadkazmii
Copy link
Contributor

This PR uses edx_django_utils.plugins to add pluggable_override to the refund_entitlement method for a customized implementation without affecting the open-source code.

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner February 12, 2025 12:51
@syedsajjadkazmii syedsajjadkazmii changed the base branch from master to program-migration February 12, 2025 12:53
@syedsajjadkazmii syedsajjadkazmii changed the title feat: override refund_entitlement feat: make refund_entitlement pluggable Feb 13, 2025
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syedsajjadkazmii syedsajjadkazmii changed the base branch from program-migration to master February 17, 2025 05:54
@syedsajjadkazmii syedsajjadkazmii merged commit c05a3f3 into master Feb 17, 2025
49 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/SONIC-862 branch February 17, 2025 05:55
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants