-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-73 pr for edx platform repository (Creating waffle flag for integration towards created_submission in the edx-submission repo) #36258
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @gabrielC1409! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
ed480c7
to
35a3276
Compare
5c56646
to
35a3276
Compare
@@ -0,0 +1,58 @@ | |||
############################################################### | |||
Integration of Waffle Switch for XQueue Submission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this ADR should be in the https://github.com/openedx/edx-platform/tree/58834c6bdc20fae182eca4aa4ce7402cc14dfd47/xmodule/docs/decisions directory, and the file name should include "xqueue" in it (we have a ton of waffle switches, so the title "create-waffle-switch" is really not specific enough)
Your conventional commit names are inaccurate. A new ADR should use the |
9ff3e09
to
422d08e
Compare
Description
This pull request introduces several improvements and updates to the xmodule/layer module of the edx-platform repository. The main changes include:
Refactoring of xqueue_interface.py and xqueue_submission.py: The functions for sending and handling responses that a student sends within an exercise created in a course have been optimized. For this, the original functionality of sending the submission to Xqueue was maintained, but for this improvement a Waffle Switch was created, where within the LMS Administration it was possible to create and from the tutor env in the development.py file this environment variable is found pointing to the Switch created in the LMS Administration. This Switch was created within Xqueue_interfaces.py when you want to test or not this new functionality of sending the submit to created_submission.
Motivation:
These improvements aim to optimize the performance and maintainability of the XQueue-related code, ensuring a more robust and efficient integration into the evaluation workflow.
Tests performed:
The tests in test_xqueue_interface.py and test_xqueue_submission.py have been reviewed and updated to ensure compatibility with the new modifications and improve test coverage.
Additional considerations:
No negative impacts on other parts of the system are anticipated, as the changes are limited to the xmodule/layer module.
Recommendations for review:
A detailed review of the modified functions in xqueue_interface.py and xqueue_submission.py, as well as the new tests added in the corresponding files, is suggested.