Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove duplicate imports of js files in instructor dashboard pages #36289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rehmansheikh222
Copy link

@rehmansheikh222 rehmansheikh222 commented Feb 21, 2025

I was working on enabling the dark theme in the Instructor Dashboard using Tutor Indigo, which adds the dark theme file to the application JavaScript pipeline. However, the dark theme toggle wasn’t working, no matter how many times I clicked it. After digging into the issue, I found that the event listener for the theme toggle was being added twice, causing it to do nothing.

The reason for this double event listener was that the Instructor Dashboard was importing the application JavaScript pipeline twice. Here’s how it happened: The Instructor Dashboard inherits from main.html, which includes the application pipeline. On top of that, the Instructor Dashboard itself explicitly imports the application pipeline again. This led to every JavaScript file in the application pipeline, including the dark theme file, being loaded twice.

To fix this, I removed the redundant import of the application pipeline from the Instructor Dashboard. Now, the application pipeline is loaded only once, ensuring that event listeners are registered correctly. This change fixed the dark theme toggle issue and prevents similar problems from happening in the future.

@openedx-webhooks
Copy link

Thanks for the pull request, @rehmansheikh222!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 21, 2025
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 21, 2025
@e0d
Copy link
Contributor

e0d commented Feb 21, 2025

@rehmansheikh222 should you be covered under the Arbisoft entity CLA? If so, please ask your HR department to reach out and add you so the CLA check will pass.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants