fix: Remove duplicate imports of js files in instructor dashboard pages #36289
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on enabling the dark theme in the Instructor Dashboard using Tutor Indigo, which adds the dark theme file to the application JavaScript pipeline. However, the dark theme toggle wasn’t working, no matter how many times I clicked it. After digging into the issue, I found that the event listener for the theme toggle was being added twice, causing it to do nothing.
The reason for this double event listener was that the Instructor Dashboard was importing the application JavaScript pipeline twice. Here’s how it happened: The Instructor Dashboard inherits from main.html, which includes the application pipeline. On top of that, the Instructor Dashboard itself explicitly imports the application pipeline again. This led to every JavaScript file in the application pipeline, including the dark theme file, being loaded twice.
To fix this, I removed the redundant import of the application pipeline from the Instructor Dashboard. Now, the application pipeline is loaded only once, ensuring that event listeners are registered correctly. This change fixed the dark theme toggle issue and prevents similar problems from happening in the future.