Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove CONTENT_GROUPS_FOR_TEAMS waffle flag #36290

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BryanttV
Copy link
Contributor

Description

This PR removes the CONTENT_GROUPS_FOR_TEAMS Waffle Flag and all related code. With this change, the connection of teams with content groups will always be available.

Supporting information

  • [DEPR ticket here]

Testing instructions

  1. Create a Tutor environment.
  2. Create a mount of edx-platform with the changes in this branch.
  3. Enable teams for the course in Studio > [Your Course] > Content > Pages & Resources > Teams > Teams toggle
  4. Create a few team sets (or groups) from the Course Authoring MFE for your course
  5. Then, go to the LMS > [Your Course] > Teams and create a few teams within those team-set (or topics, or groups)
  6. As a student, try loading the sections of the course, you'll be able to load each course section. You'll be able to see them as usual.
  7. Now, restrict topics for each team as you would with cohorts or enrollment tracks
  8. As a student, try loading the course sections again. You won't be able to see any content.
  9. As a student, join one of the teams and try again: you'll be able to see the content within your team
  10. As a student, join the other team: you'll be able to see the content within both teams

For more detailed testing instructions, please refer to the PR cover letter with the original implementation. The only change is that it's no longer necessary to create the Waffle Flag in the course to use the functionality.

Deadline

None

Other information

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 21, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants