-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Course: Libraries Page: Libraries Tab: list all library-sourced content in the course #1565
Comments
@jmakowski1123 @lizc577 @sdaitzman @marcotuts The designs are missing following details and also have some open tasks:
cc: @bradenmacdonald |
Hi @navinkarkera, the designs referenced on this ticket are quite out of date. We'll add this as a priority and try to provide some updated designs soon.
I'm not sure I follow, is this a question about what happens when you delete content in a course that was added from a library? Or about what happens when you delete content in a library that was added to a course?
I think the libraries can be sorted alphabetically, and their contents can be sorted either by most recently modified locally or by their first course appearance. We can include this in updated designs for this ticket.
Can also include this in updated designs for this ticket.
I think the alert can appear just on the course outline page. The Review Content Updates tag in the libraries page will have an update count badge, so the user will have a clear indication already there (and will most likely be on the page intending to sync changes). CC @edschema |
@sdaitzman Thank you!
Yes, what should be allowed actions when a library block that is used in a course is deleted?
I think contents can be ordered based on the library block modified date. Ordering based on its location in course would be slow as mentioned by Braden here so would it be ok to sort by name or modified date first and them implement it in a separate task? |
@navinkarkera thanks for clarifying, these are good questions.
There are a few options:
I would lean toward the first option to avoid increasing scope, and treat the second as a future improvement for when it's possible to restore deleted content. When adding library units to courses is implemented, if local unit instances are read-only to start, we can incrementally add a "broken link" icon in course authoring to make it clear why read-only local unit instances can't be modified (or we could actually break the link and make them editable). @jmakowski1123 does that approach make sense to you?
If needed, I feel okay about sorting by modified date first, with name as another option, and ordering by location in course as a later enhancement. |
We already show a broken link icon in course authoring. Also, deleted library blocks can be restored via authoring frontend within first few seconds of deletion via undo option. I think displaying a broken icon would be easier to implement now. |
Posting screencast of my current implementation for reference. vokoscreenNG-2025-02-14_21-20-42.webm |
Thanks @navinkarkera! Just confirming the logic for ignore changes: if you ignore changes, can you still accept future updates to the same component? |
If adding the broken link icon is feasible, I think it makes sense to do that now. |
Yes, we are reusing the review modal from course authoring page.
It takes user to
Yes, that is the current behaviour. So just to confirm, we should also add this alert to course outline page. |
Posting screencast of current implementation state. vokoscreenNG-2025-02-21_17-01-12.webm@sdaitzman Please let me know when the designs are ready, I can make the required changes. |
Hi @navinkarkera thank you, this is great progress and looks really good. For Teak, I think we can simplify some of this to lay the groundwork for some more full-featured library object management in Ulmo or later. An updated design is attached below, and you can find it in Figma as well. We're still making some minor updates to the review tab, but here are the steps I think we should take for Teak:
I want to make sure to resolve some potential issues when the same library component gets used in multiple places in a course and has different local edits.
CC @jmakowski1123 for confirmation on this product direction, and @edschema (who is now working on updated designs for #1566) |
Based on the team sync today, we decided to stay with the current implementation of the preview tabs showing local library versions. We also decided to stay wtih the current implementation, that each reuse of a library object will display as its own sync. |
Designs are being revised but the initial version is here in Figma: https://www.figma.com/design/Y3gSyrpG6uncUUfjK7eQuo/Content-Libraries-v2.1-%5BOpen-edX%5D?node-id=1549-46333&t=hhz5Rljy8gvcwIUY-4
The text was updated successfully, but these errors were encountered: