Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TNL-11886] Fix: Resolve Course Optimizer Scanning Bug #1666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Faraz32123
Copy link

@Faraz32123 Faraz32123 commented Feb 19, 2025

  • TNL-11886

  • Corrected LINK_CHECK_STATUSES.IN_PROGRESS value that is sent by backend. As aligned with backend, it should be this.

@Faraz32123 Faraz32123 self-assigned this Feb 19, 2025
@Faraz32123 Faraz32123 changed the title fix: Resolve Course Optimizer Scanning Bug [TNL-11886] Fix: Resolve Course Optimizer Scanning Bug Feb 19, 2025
@Faraz32123 Faraz32123 requested review from jesperhodge and a team February 19, 2025 05:45
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (59243b0) to head (9a5f680).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
+ Coverage   93.30%   93.33%   +0.02%     
==========================================
  Files        1101     1107       +6     
  Lines       21856    22002     +146     
  Branches     4741     4753      +12     
==========================================
+ Hits        20393    20535     +142     
- Misses       1392     1396       +4     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mfarhan943 mfarhan943 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hinakhadim
Copy link

LGTM!

- Corrected LINK_CHECK_STATUSES.IN_PROGRESS value that is sent by backend.
@Faraz32123 Faraz32123 force-pushed the faraz/TNL-11886-fix-course-optimizer-during-scanning branch from b67fb2c to 9a5f680 Compare February 20, 2025 03:09
Copy link

@hinakhadim hinakhadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and this is working fine. Good catch!

@hinakhadim
Copy link

Make sure test-cases are working fine before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants