-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parsing text input problems #1679
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 93.33% 93.34% +0.01%
==========================================
Files 1108 1108
Lines 22045 22050 +5
Branches 4674 4757 +83
==========================================
+ Hits 20575 20583 +8
+ Misses 1405 1396 -9
- Partials 65 71 +6 ☔ View full report in Codecov by Sentry. |
dd3d777
to
ae97545
Compare
Description
Fix for #1460
Discovered other issues while working on above issue.
Supporting information
Private-ref
: FAL-4087Testing instructions
Other information
Found one more issue but did not fix it as part of this PR:
If incorrect answers are entered before correct answer in text input problems, they are lost.