Adds Annotatable XBlock extracting from edx-platform repo #5
Conversation
irtazaakram
force-pushed
the
annotatable
branch
from
98a068e to
c329afa
Compare
irtazaakram
force-pushed
the
annotatable
branch
from
be2ce6a to
f345ff3
Compare
irtazaakram
force-pushed
the
annotatable
branch
from
8d1b35d to
a6905b1
Compare
| Generate initial i18n with dummy method. | ||
| """ | ||
| return translation.gettext_noop("Dummy") | ||
| def resource_string(self, path): |
There was a problem hiding this comment.
We should use xblock.utils.resources module to load the resources
| var annotationsHidden = false; | ||
| var instructionsHidden = false; | ||
|
|
||
| var el = element; |
| var toggleAnnotationsSelector = '.annotatable-toggle-annotations'; | ||
| var toggleInstructionsSelector = '.annotatable-toggle-instructions'; | ||
| var instructionsSelector = '.annotatable-instructions'; | ||
| var sectionSelector = '.annotatable-section'; |
There was a problem hiding this comment.
Some selectors are un-used, shouldn't we remove them to keep code clean.
| var $el = $(element); | ||
|
|
||
| if (_debug) { | ||
| console.log('loaded Annotatable'); |
There was a problem hiding this comment.
'Annotatable XBlock Loaded'
sounds better
We should put it at end of init() function
| } | ||
|
|
||
| function toggleAnnotations() { | ||
| annotationsHidden = !annotationsHidden; |
There was a problem hiding this comment.
Extra code line
var hide = !annotationsHidden;| /* | ||
| Update the position object (used by qTip2 to show the tip after the move event) | ||
| */ | ||
| $.extend(position, { |
There was a problem hiding this comment.
Some functions are not returning value like in BuiltIn XBlock code, shouldn't we follow the same?
| instructionsHidden = !instructionsHidden; | ||
| var hide = instructionsHidden; |
| @@ -1,9 +1,190 @@ | |||
| /* CSS for AnnotatableBlock */ | |||
| @import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700"); | |||
| instructions = xmltree.find("instructions") | ||
| if instructions is not None: | ||
| instructions.tag = "div" | ||
| xmltree.remove(instructions) |
There was a problem hiding this comment.
Instruction is not removing from the xml tree as its appearing 2 times within XBlock.
We should fix it (though it exist in the Built In Xblock as well), seems a bug
We should also write a test case of this deletion
|
|
||
|
|
||
| class TestAnnotatableBlock(TestCase): | ||
| """Tests for AnnotatableBlock""" | ||
| class MockRuntime(Runtime): |
There was a problem hiding this comment.
We should use the TestRuntimes exist in the xblock.test api
Adds annotatable xblock extracting from edx-platform repo
Test PR
Make a test PR on
edx-platformlike this to run test cases on under development PR.File references:
xblocks_contrib/annotatable/annotatable.pyhas been extracted fromxblocks_contrib/annotatable/templates/annotatable.htmlhas been extracted fromxblocks_contrib/annotatable/templates/annotatable_editor.htmlhas been extracted fromxblocks_contrib/annotatable/static/js/src/annotatable.jshas been extracted fromxblocks_contrib/annotatable/static/js/src/annotatable_editor.jshas been extracted fromxblocks_contrib/annotatable/static/css/annotatable.csshas been extracted fromxblocks_contrib/annotatable/static/css/annotatable_editor.csshas been extracted fromxblocks_contrib/annotatable/tests/test_annotatable.pyhas been extracted fromAcceptance Criteria: