Merge pull request #2 from openeuropa/EWPP-4665

EWPP-4665: Sync with drupal core phpstan

composer.json

@@ -4,7 +4,7 @@
   "license": "EUPL-1.2",
   "require": {
     "php": ">=8.1",
-    "openeuropa/code-review": "OEL-3328-dev",
+    "openeuropa/code-review": "^3.0",
     "drupal/coder": "^8.3.16",
     "mglaman/phpstan-drupal": "^1.2",
     "phpstan/phpstan-deprecation-rules": "^1.2",

dist/drupal-conventions.yml

@@ -46,3 +46,4 @@ parameters:
   tasks.phpcs.standard: ./vendor/drupal/coder/coder_sniffer/Drupal
   tasks.phpcs.triggered_by: '%drupal-conventions.triggered_by%'
   tasks.phpstan.triggered_by: '%drupal-conventions.triggered_by%'
+  tasks.phpstan.configuration: ./vendor/openeuropa/code-review-drupal/dist/phpstan.drupal.neon

dist/phpstan.drupal.neon

@@ -0,0 +1,10 @@
+parameters:
+  ignoreErrors:
+    # new static() is a best practice in Drupal, so we cannot fix that.
+    - "#^Unsafe usage of new static#"
+
+    # Ignore common errors for now.
+    - "#Drupal calls should be avoided in classes, use dependency injection instead#"
+    - "#^Plugin definitions cannot be altered.#"
+    - "#^Class .* extends @internal class#"
+    - identifier: missingType.iterableValue