#83 Make the package compatible with php 8.3 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
reviewed
Dec 10, 2024
composer.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| "cweagans/composer-patches": "^1 || ^2", | |||
| "php-http/logger-plugin": "^1", | |||
| "php-http/message": "~1.13", | |||
| "phpro/soap-client": "~2.4", | |||
| "phpro/soap-client": ">=3 <4", | |||
There was a problem hiding this comment.
Hi,
what is the difference between >=3 <4 and ^3
There was a problem hiding this comment.
Hello,
No difference, it's just that ^3 is the shorter writing of >=3 <4.
Do you prefer the shorter writing ?
There was a problem hiding this comment.
Hi,
Thanks for the clarification! I don’t have a strong preference personally, but it does seem like the ^3 syntax is more widely adopted in the PHP community. Given the Minimum Description Length principle, which suggests using the most concise and clear format, it might make sense to stick with the shorter ^3 notation.
Thanks again for the explanation!
There was a problem hiding this comment.
I changed it to the shorter writing.
rachidtarsimi
force-pushed
the
feature/#83-compatibility-php-8.3
branch
from
421d12d to
ff54761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the package compatible with PHP 8.3
Change log
Commands
#Using php 8.1, 8.2 & 8.3 run composer install