Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api docs for logging endpoint #1288

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

nlochschmidt
Copy link
Contributor

Description

  • Corrects indentation for the /system/logs endpoint (summary,...)
  • Fixes schema validation for LogEntry

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

Fixes errors in the api docs as raised in #1287

How Has This Been Tested?

Loaded the API Docs into Swagger Editor and they validate without errors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Corrects indentation for the /system/logs endpoint (summary,...)
- Fixes schema validation for LogEntry

Signed-off-by: Niklas Lochschmidt <[email protected]>
@nlochschmidt
Copy link
Contributor Author

I am not sure why the build has failed.
@alexellis could you have a look? https://travis-ci.org/openfaas/faas/builds/574302332

The build ran through fine on my fork of faas 🤷‍♂(see https://travis-ci.org/nlochschmidt/faas/builds/574300172)

@alexellis
Copy link
Member

I can't tell why, but it's unrelated to your change.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis removed the request for review from LucasRoesler August 21, 2019 08:17
@alexellis alexellis merged commit 2b92ee6 into openfaas:master Aug 21, 2019
@nlochschmidt
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants