Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create variables for window parameters #1890

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

zebbd
Copy link

@zebbd zebbd commented Jan 12, 2025

this will simplify the implementation of some settings like vsync switching

@player-03
Copy link
Contributor

Where would these variables be used? It looks like they're only available inside ApplicationMain, which seems like the wrong place to implement new features.

@zebbd
Copy link
Author

zebbd commented Jan 12, 2025

Where would these variables be used? It looks like they're only available inside ApplicationMain, which seems like the wrong place to implement new features.

you can change them with macros

@player-03
Copy link
Contributor

Technically you can already change them with macros, just a bit less easily.

More importantly, macros run at compile time, and you already have a perfectly good way to set vsync at compile time: <window vsync="false" />. What's the benefit of using macros instead of project.xml?

@joshtynjala
Copy link
Member

joshtynjala commented Jan 13, 2025

you already have a perfectly good way to set vsync at compile time: <window vsync="false" />

And if you don't want to modify project.xml for a temporary change, you can override vsync on the command line too.

lime build windows --window-vsync=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants