Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Added PL translations to some categories #11291

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

franiis
Copy link
Contributor

@franiis franiis commented Jan 26, 2025

I added translations for the ones I saw in my products and were not translated.

I removed the "Słodycze" from en:Candies and moved to en:Confectioneries - I believe it's a better match to PL language.

I don't have a docker setup to run make lint_taxonomies. Sorry. I tried to remove ending white characters from the lines manually

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

I added translations for the ones I saw in my products and were not translated.

I removed the "Słodycze" from en:Candies and moved to en:Confectioneries - I believe it's a better match to PL language.
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Jan 26, 2025
@franiis franiis changed the title Added PL translations to some categories [taxonomy] Added PL translations to some categories Jan 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.33%. Comparing base (b8651b8) to head (36a6c51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11291   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files          79       79           
  Lines       22510    22510           
  Branches     5387     5387           
=======================================
  Hits        11105    11105           
  Misses      10045    10045           
  Partials     1360     1360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-throwaway
Copy link
Contributor

@franiis you can just comment /lint on this PR to reformat the taxonomies. Also you will need to change your prefix to taxonomy:.

@teolemon teolemon added the 🇵🇱 Polish https://pl.openfoodfacts.org/ label Jan 27, 2025
@franiis franiis changed the title [taxonomy] Added PL translations to some categories taxonomy: Added PL translations to some categories Jan 27, 2025
@franiis
Copy link
Contributor Author

franiis commented Jan 27, 2025

/lint

@franiis
Copy link
Contributor Author

franiis commented Jan 27, 2025

@franiis you can just comment /lint on this PR to reformat the taxonomies. Also you will need to change your prefix to taxonomy:.

Thank you, I updated the title and run /lint

@github-throwaway
Copy link
Contributor

/update_tests_results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🇵🇱 Polish https://pl.openfoodfacts.org/ 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants