Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: more rate limiting ignores #11332

Merged
merged 4 commits into from
Feb 7, 2025
Merged

chore: more rate limiting ignores #11332

merged 4 commits into from
Feb 7, 2025
+35 −24

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Feb 6, 2025 •
edited
Loading

  • move rate limiting config to common config
  • add more ips to ignore

@github-actions github-actions bot added the config label Feb 6, 2025
@alexgarel alexgarel marked this pull request as ready for review February 6, 2025 09:44
@alexgarel alexgarel requested a review from a team as a code owner February 6, 2025 09:44
@stephanegigandet stephanegigandet enabled auto-merge (squash) February 7, 2025 09:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stephanegigandet stephanegigandet merged commit 7b07ad0 into main Feb 7, 2025
12 of 13 checks passed
@stephanegigandet stephanegigandet deleted the chore-rate-limit-more-ips branch February 7, 2025 10:34
alexgarel
alexgarel commented Feb 7, 2025
View reviewed changes
lib/ProductOpener/Config.pm
Comment on lines +35 to +37
# %options will be redefined by autoload below
# but we need it to avoid Perl complaining
%ProductOpener::Config:: % options = ();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanegigandet our commits did cross, and so I realize this wasn't needed !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgarel ah right, here is a PR to remove it: #11345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@teolemon teolemon teolemon approved these changes

Assignees

@alexgarel alexgarel

Labels
config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgarel @teolemon @stephanegigandet