Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: food contact packagings for chocolate bars #11343

Merged
merged 9 commits into from
Feb 12, 2025
Merged

Conversation

stephanegigandet
Copy link
Contributor

Some fixes + support for chocolate bars

@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Display 🧪 integration tests labels Feb 7, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.40%. Comparing base (d1346e7) to head (f2b64ba).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/ProductOpener/PackagingFoodContact.pm 80.00% 2 Missing and 1 partial ⚠️
lib/ProductOpener/Display.pm 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11343      +/-   ##
==========================================
+ Coverage   49.32%   49.40%   +0.08%     
==========================================
  Files          80       80              
  Lines       22576    22589      +13     
  Branches     5397     5400       +3     
==========================================
+ Hits        11135    11161      +26     
+ Misses      10086    10077       -9     
+ Partials     1355     1351       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanegigandet stephanegigandet merged commit c485494 into main Feb 12, 2025
13 checks passed
@stephanegigandet stephanegigandet deleted the food-contact2 branch February 12, 2025 09:15
stephanegigandet pushed a commit that referenced this pull request Feb 12, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.58.0](v2.57.0...v2.58.0)
(2025-02-12)


### Features

* petfood-nutrition-facts
([#11188](#11188))
([f101551](f101551))


### Bug Fixes

* disable rate limiting for internal trafic
([#11327](#11327))
([17b9a54](17b9a54))
* food contact packagings for chocolate bars
([#11343](#11343))
([c485494](c485494))
* remove %options
([#11345](#11345))
([3491318](3491318))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Display 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧪 tests
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants