Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Brands taxonomy #6683

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: Brands taxonomy #6683

wants to merge 13 commits into from

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Apr 23, 2022

Description

The brands taxonomy, which should be used for:

  • normalisation - no more typo's
  • owner - who owns the brand

@aleene aleene self-assigned this Apr 23, 2022
@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Apr 23, 2022
@aleene aleene marked this pull request as draft April 23, 2022 15:51
@aleene aleene changed the title Brands taxonomy feat: Brands taxonomy Apr 23, 2022
@aleene aleene linked an issue Apr 24, 2022 that may be closed by this pull request
Make brands a taxonomized field #5208
Open
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jul 28, 2022
@teolemon teolemon added the brands Not taxonomized yet. https://wiki.openfoodfacts.org/Brands label Dec 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2
Copy link
Collaborator

This is an amazing work @aleene!

Do you think that we could include the market where each brand is located as well? (#2954)

Something like:
brand_locations:en:France, Germany, Italy

@teolemon
Copy link
Member

teolemon commented Nov 9, 2023

Can we take this out of draft and merge @aleene ?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon
Copy link
Member

@aleene ok to merge ?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label May 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Feb 14, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.37%. Comparing base (2cac87f) to head (dedd31b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6683      +/-   ##
==========================================
+ Coverage   41.37%   49.37%   +7.99%     
==========================================
  Files          79       80       +1     
  Lines       22546    22604      +58     
  Branches     5398     5407       +9     
==========================================
+ Hits         9329    11161    +1832     
+ Misses      12042    10091    -1951     
- Partials     1175     1352     +177

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aleene aleene

Labels
brands Not taxonomized yet. https://wiki.openfoodfacts.org/Brands ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
🍊 Open Food Facts Server issues
Status: PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make brands a taxonomized field
4 participants
@aleene @benbenben2 @teolemon @codecov-commenter