Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace all Snackbar by SmoothFloatingSnackbar #6169

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 9, 2025

It will force this view:
IMG_1762

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 6.33%. Comparing base (4d9c7fc) to head (34c8976).
Report is 630 commits behind head on develop.

Files with missing lines Patch % Lines
...h_app/lib/generic_lib/widgets/smooth_snackbar.dart 0.00% 6 Missing ⚠️
...pp/lib/pages/product/common/product_list_page.dart 0.00% 5 Missing ⚠️
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% 3 Missing ⚠️
...mooth_app/lib/pages/personalized_ranking_page.dart 0.00% 2 Missing ⚠️
...pp/lib/pages/product/common/product_refresher.dart 0.00% 2 Missing ⚠️
...ckages/smooth_app/lib/pages/offline_data_page.dart 0.00% 1 Missing ⚠️
...ib/pages/preferences/user_preferences_rate_us.dart 0.00% 1 Missing ⚠️
.../product/common/product_list_item_popup_items.dart 0.00% 1 Missing ⚠️
...ooth_app/lib/pages/search/search_history_view.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6169      +/-   ##
==========================================
- Coverage     9.54%   6.33%   -3.22%     
==========================================
  Files          325     451     +126     
  Lines        16411   25960    +9549     
==========================================
+ Hits          1567    1644      +77     
- Misses       14844   24316    +9472     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
LGTM

@teolemon teolemon merged commit 54b9f40 into openfoodfacts:develop Jan 10, 2025
6 checks passed
@g123k g123k deleted the smooth_snackbar branch January 13, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants