Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Language selector + ingredients (text field + outdated) #6170

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 9, 2025

Hi!

This PR brings 3 minor changes:

Ingredients/packaging

  • Tapping outside the ingredients/packaging textfield will close the keyboard
  • The outdated icon on ingredients/packaging screen will show some explanations
    IMG_1772

Photo Gallery

  • In the gallery, languages with photos will have a camera icon, instead of a ☑

IMG_1763

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 3.22581% with 30 lines in your changes missing coverage. Please review.

Project coverage is 6.33%. Comparing base (4d9c7fc) to head (75248bc).
Report is 630 commits behind head on develop.

Files with missing lines Patch % Lines
...app/lib/pages/product/edit_ocr/edit_ocr_image.dart 0.00% 12 Missing ⚠️
.../smooth_app/lib/widgets/v2/smooth_buttons_bar.dart 0.00% 8 Missing ⚠️
...pp/lib/cards/product_cards/product_title_card.dart 0.00% 3 Missing ⚠️
...lib/pages/product/edit_ocr/edit_ocr_textfield.dart 0.00% 2 Missing ⚠️
...mooth_app/lib/pages/product/edit_product_page.dart 0.00% 2 Missing ⚠️
...ric_lib/buttons/smooth_large_button_with_icon.dart 0.00% 1 Missing ⚠️
...app/lib/generic_lib/widgets/language_selector.dart 0.00% 1 Missing ⚠️
...th_app/lib/pages/product/edit_language_tabbar.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6170      +/-   ##
==========================================
- Coverage     9.54%   6.33%   -3.22%     
==========================================
  Files          325     451     +126     
  Lines        16411   25984    +9573     
==========================================
+ Hits          1567    1645      +78     
- Misses       14844   24339    +9495     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k g123k changed the title fix: Language selector + ingredients text field fix: Language selector + ingredients (text field + outdated) Jan 10, 2025
@github-actions github-actions bot added the ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users label Jan 10, 2025
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have possibly added the image icon (instead of the camera which implies an action)

@g123k
Copy link
Collaborator Author

g123k commented Jan 10, 2025

I would have possibly added the image icon (instead of the camera which implies an action)

Which one would you prefer in that list:
Screenshot 2025-01-10 at 09 13 24

@teolemon
Copy link
Member

The penultimate one is interesting, and we could badge it with a clock if obsolete

@g123k
Copy link
Collaborator Author

g123k commented Jan 10, 2025

IMG_B0F3C9304E11-1

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
LGTM

builder: (BuildContext context) {
return SmoothModalSheet(
title: appLocalizations.product_image_outdated_explanations_title,
prefixIndicator: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would somehow put the outdated icon here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the header of a modal sheet can't have an icon.

But now that we have modal sheets for Help, I think I will add a better layout for the content (including that kind of image)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the header of a modal sheet can't have an icon.

What about the starting bold dot?
Screenshot_20250110_100206_Chrome

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "new" design, modal sheets only have this indicator.
Hence, this is a boolean.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how the "new" design may be improved, using as an indicator: a dot, nothing, or a specified icon.

@teolemon teolemon merged commit 863aa76 into openfoodfacts:develop Jan 10, 2025
6 checks passed
@g123k g123k deleted the ingedients_minor branch January 13, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🌐 l10n 🥫 Product page
Development

Successfully merging this pull request may close these issues.

4 participants