Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add price with the "Edit UI" #6171

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 9, 2025

A pure UI PR:

Untitled

cc @raphodn

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.

Project coverage is 6.33%. Comparing base (4d9c7fc) to head (c8fd473).
Report is 630 commits behind head on develop.

Files with missing lines Patch % Lines
...ooth_app/lib/pages/prices/price_location_card.dart 0.00% 22 Missing ⚠️
...s/smooth_app/lib/pages/prices/price_date_card.dart 0.00% 17 Missing ⚠️
.../smooth_app/lib/pages/prices/price_proof_card.dart 0.00% 15 Missing ⚠️
...h_app/lib/pages/prices/product_price_add_page.dart 0.00% 6 Missing ⚠️
...smooth_app/lib/pages/prices/price_amount_card.dart 0.00% 3 Missing ⚠️
...ooth_app/lib/pages/prices/price_currency_card.dart 0.00% 3 Missing ⚠️
...h_app/lib/pages/prices/price_add_product_card.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6171      +/-   ##
==========================================
- Coverage     9.54%   6.33%   -3.22%     
==========================================
  Files          325     451     +126     
  Lines        16411   25956    +9545     
==========================================
+ Hits          1567    1644      +77     
- Misses       14844   24312    +9468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
Not a big fan of the tap dancing around the floating action button, but generally speaking it looks good.

@g123k
Copy link
Collaborator Author

g123k commented Jan 10, 2025

Hi @g123k! Not a big fan of the tap dancing around the floating action button, but generally speaking it looks good.

Thanks for your feedback.
I take the opportunity to ask you why, when there's a price tag, the "Add an item" section is displayed?
Shouldn't we hide it?

@monsieurtanuki
Copy link
Contributor

Hi @g123k! Not a big fan of the tap dancing around the floating action button, but generally speaking it looks good.

Thanks for your feedback. I take the opportunity to ask you why, when there's a price tag, the "Add an item" section is displayed? Shouldn't we hide it?

I guess there could be 2 price tags in the same pictures, couldn't it?

@teolemon
Copy link
Member

We could have a counter badge on the minimized FAB. For now, merging.

@teolemon teolemon merged commit 58c53fe into openfoodfacts:develop Jan 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants