Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative tolerance #604

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix relative tolerance #604

wants to merge 8 commits into from

Conversation

lilyminium
Copy link
Contributor

Description

Fixes #592

Changes:

  • changes which uncertainty is compared
  • Adds tests of directly executing a Simulation graph, as well as with a server
  • Adds test data from an example run
  • Adds some helper functions to tests

Blocked by / follows #602.

Questions

  • I've started adding test data from example runs -- this is helpful firstly in having an example of test data, and secondly for avoiding re-execution of workflows during tests. However there are a lot of files -- should these be compressed and uncompressed on-the-fly? Pros for compression are that the number of files changed is much lower. Cons is that the tarball may wind up being quite large (10+MB), and any changes to an individual file will change the entire compressed directory.

Status

  • Ready to go

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (3b38655) to head (1b1123e).

Additional details and impacted files

@lilyminium lilyminium mentioned this pull request Jan 23, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative uncertainty does not result in successful properties unless relative_uncertainty > 1.0
1 participant