Pydantic v1/v2 compatibility #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I heard from the MolSSI folks that there is no plan to add pydantic 2 compatibility to the legacy QC stack, but that the upcoming major releases of the QC stack will only support pydantic 2. Could you retarget this PR to QCSubmit's |
|
Revisiting this now with QCFractal 0.52 including v1/v2 dual-compatibility. |
|
The new QCPortal should work v1/v2, but the builds are pinned to v1 |
The fixture `fulltest_client` is not present in QCFractal https://github.com/MolSSI/QCFractal/blob/v0.52/qcarchivetesting/qcarchivetesting/testing_fixtures.py
j-wags
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Awesome, thanks @mattwthompson. One blocking comment, and please update the releasenotes before merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds runtime compatibility with Pydantic v2, though does not take advantage of any new features.
Todos
Notable points that this PR has either accomplished or will accomplish.
Status